From da0f19afd9ace39e8df18f995d0664d1b761993c Mon Sep 17 00:00:00 2001 From: Benoit Lemoine Date: Mon, 18 Nov 2024 08:52:17 -0500 Subject: [PATCH] fix(config): keep the lookup value as passed The previous version was transforming the lookup parameter to a string. Closes #4894 --- packages/dd-trace/src/config.js | 2 +- packages/dd-trace/test/config.spec.js | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/dd-trace/src/config.js b/packages/dd-trace/src/config.js index 05de1cdf600..4dbc19dfc15 100644 --- a/packages/dd-trace/src/config.js +++ b/packages/dd-trace/src/config.js @@ -951,7 +951,7 @@ class Config { this._setBoolean(opts, 'llmobs.agentlessEnabled', options.llmobs?.agentlessEnabled) this._setString(opts, 'llmobs.mlApp', options.llmobs?.mlApp) this._setBoolean(opts, 'logInjection', options.logInjection) - this._setString(opts, 'lookup', options.lookup) + this._setValue(opts, 'lookup', options.lookup) this._setBoolean(opts, 'openAiLogsEnabled', options.openAiLogsEnabled) this._setValue(opts, 'peerServiceMapping', options.peerServiceMapping) this._setBoolean(opts, 'plugins', options.plugins) diff --git a/packages/dd-trace/test/config.spec.js b/packages/dd-trace/test/config.spec.js index f840dcd4a13..41c95f02b95 100644 --- a/packages/dd-trace/test/config.spec.js +++ b/packages/dd-trace/test/config.spec.js @@ -1526,6 +1526,13 @@ describe('Config', () => { expect(config.tags).to.include({ foo: 'bar', baz: 'qux' }) }) + it('should not transform the lookup parameter', () => { + const lookup = () => 'test' + const config = new Config({ lookup: lookup }) + + expect(config.lookup).to.equal(lookup) + }) + it('should not set DD_INSTRUMENTATION_TELEMETRY_ENABLED if AWS_LAMBDA_FUNCTION_NAME is present', () => { process.env.AWS_LAMBDA_FUNCTION_NAME = 'my-great-lambda-function'