Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying supported Rails versions #3911

Open
smasato opened this issue Sep 13, 2024 · 3 comments
Open

Clarifying supported Rails versions #3911

smasato opened this issue Sep 13, 2024 · 3 comments
Assignees
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations

Comments

@smasato
Copy link

smasato commented Sep 13, 2024

Current behaviour

The documentation does not state whether versions newer than Rails 6.1 are supported.

**Supported versions**
| MRI Versions | JRuby Versions | Rails Versions |
| ------------ | -------------- | -------------- |
| 2.5 | | 4.2 - 6.1 |
| 2.6 - 2.7 | 9.2 - 9.3 | 5.0 - 6.1 |
| 3.0 - 3.2 | 9.4 | 6.1 |

Expected behaviour

The documentation will state whether versions newer than Rails 6.1 are supported.
Or state the minimum version supported.

Steps to reproduce

How does datadog help you?

Environment

  • datadog version:
  • Configuration block (Datadog.configure ...):
  • Ruby version:
  • Operating system:
  • Relevant library versions:
@smasato smasato added bug Involves a bug community Was opened by a community member labels Sep 13, 2024
@p-datadog p-datadog self-assigned this Sep 18, 2024
@delner
Copy link
Contributor

delner commented Sep 24, 2024

Hi @smasato! Thanks for the question!

Looking at our code/build, it doesn't look like we're testing against newer versions of Rails, hence why the documentation reads this way. It doesn't mean our Rails instrumentation won't work against newer versions (minimum support is version 4), but it does mean we're not tracking feature support/compatibility for Rails versions greater than 6.1.

I can ask our team about expanding our official support. What version of Rails are you using?

@bouwkast
Copy link

@smasato we've scheduled work to expand our testing for the latest Rails.

As @delner mentioned, the current state is that our tests for Rails ends with the last major version of 6.1.

We'll update you with the status of this, if the tests for the latest of Rails all pass then it'd be a simple documentation change, but if not, then we'll need to schedule additional time to get official support for v7.

But we'll keep this issue updated for those cases. Thanks again for raising this!

@delner delner added integrations Involves tracing integrations feature-request A request for a new feature or change to an existing one and removed bug Involves a bug labels Sep 24, 2024
@smasato
Copy link
Author

smasato commented Sep 29, 2024

Thank you for your prompt responses, @delner and @bouwkast !

We're currently using Rails 7.0 in our project. It's great to hear that you're planning to expand testing for the latest Rails versions. We'll keep an eye on this issue for any updates.

Thanks again for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Projects
None yet
Development

No branches or pull requests

4 participants