Process integration is not merging hiera values

[marcomusso]

When setting $hiera_processes => true, for '::datadog_agent::integrations::process' only the hiera values are considered and not the $processes parameter.

This is because the hiera lookup function is incorrect: setting the default_value to $processes doesn't mean merging the rsult of the lookup with the default_value (Default values are never merged with found values. from https://puppet.com/docs/puppet/5.2/hiera_use_function.html)

https://github.com/DataDog/puppet-datadog-agent/blob/master/manifests/integrations/process.pp#L53

I would suggest just to to $local_processes = $processes + lookup(... without default_value.

[marcomusso]

I'm testing a solution (using the same parameter name won't solve since the hiera values will override it anyway). Just an array in hiera should do the trick. Just confirm please that this is the intended behavior or not.

[marcomusso]

This works for me: marcomusso@2d1def2
PR?