Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update images file paths #1

Open
Dave-Poissant opened this issue Apr 2, 2021 · 2 comments
Open

Update images file paths #1

Dave-Poissant opened this issue Apr 2, 2021 · 2 comments
Assignees
@Dave-Poissant
Labels
good first issue Good for newcomers

Comments

@Dave-Poissant
Copy link
Owner

Dave-Poissant commented Apr 2, 2021 •
edited
Loading

Description :
Actual images file paths are absolute to everyone's local project path. This is a problem since we can't actually push this in the source code.

TCI :

  • Change absolute paths to a "relative to project paths".

Dev. Tests

  • Build is fine;
  • Tested all images by running the game, images seems fine.

Reviewer Tests
TODO!!
@Dave-Poissant Dave-Poissant added the good first issue Good for newcomers label Apr 2, 2021
@Dave-Poissant Dave-Poissant self-assigned this Apr 7, 2021
@Dave-Poissant
Copy link
Owner Author

I've used boost-filesystem library and vcpkg tool. I will need to make a ReadMe step by step guide in order to run this part of the code.

@Dave-Poissant
Copy link
Owner Author

Dave-Poissant commented Apr 7, 2021 •
edited
Loading

Commit is: 63f4401
For review

Dave-Poissant added a commit that referenced this issue Apr 7, 2021
@Dave-Poissant
Fixed refactor #1 of input
34ea0ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dave-Poissant Dave-Poissant

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dave-Poissant