From 5ed21bc234dc45fbe133bb00e4b9457734e59bdc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Niezg=C3=B3dka?= Date: Mon, 22 Jan 2024 19:21:37 +0100 Subject: [PATCH] remove errounous --- dist/index.js | 11 +---------- src/comment.js | 11 +---------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/dist/index.js b/dist/index.js index 823bd350..b6e44165 100644 --- a/dist/index.js +++ b/dist/index.js @@ -31296,7 +31296,7 @@ module.exports.createWorkflowSummaryForJumpDetection = function (evaluationResul const evaluationParameters = evaluationResult.evalParameters const evaluationConfiguration = completeConfig.evaluationConfig for (let i = 0; i < evaluationResults.length; i++) { - const resultStatus = evaluationResults[i]; + const metricName = evaluationParameters.metricNames[i]; const metricUnit = evaluationParameters.metricUnits[i]; @@ -31310,15 +31310,6 @@ module.exports.createWorkflowSummaryForJumpDetection = function (evaluationResul const ratio = evaluationParameters.is[i]; - - const metricValues = evaluationParameters.metricToDifferentBenchValues.get(metricName); - if (!metricValues) { - continue; - } - - let currBenchValue = metricValues?.current ?? 'N/A'; - let prevBenchValue = metricValues?.previous ?? 'N/A'; - let graphicalRepresentationOfRes; if (resultStatus === 'failed' || resultStatus === 'passed') { graphicalRepresentationOfRes = resultStatus === 'passed' ? '🟢' : '🔴' diff --git a/src/comment.js b/src/comment.js index 32e35d20..89b4200a 100644 --- a/src/comment.js +++ b/src/comment.js @@ -884,7 +884,7 @@ module.exports.createWorkflowSummaryForJumpDetection = function (evaluationResul const evaluationParameters = evaluationResult.evalParameters const evaluationConfiguration = completeConfig.evaluationConfig for (let i = 0; i < evaluationResults.length; i++) { - const resultStatus = evaluationResults[i]; + const metricName = evaluationParameters.metricNames[i]; const metricUnit = evaluationParameters.metricUnits[i]; @@ -898,15 +898,6 @@ module.exports.createWorkflowSummaryForJumpDetection = function (evaluationResul const ratio = evaluationParameters.is[i]; - - const metricValues = evaluationParameters.metricToDifferentBenchValues.get(metricName); - if (!metricValues) { - continue; - } - - let currBenchValue = metricValues?.current ?? 'N/A'; - let prevBenchValue = metricValues?.previous ?? 'N/A'; - let graphicalRepresentationOfRes; if (resultStatus === 'failed' || resultStatus === 'passed') { graphicalRepresentationOfRes = resultStatus === 'passed' ? '🟢' : '🔴'