Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baked cannolis not compatible with node v23 out of the box #60

Open
cephalization opened this issue Jan 11, 2025 · 1 comment
Open

Baked cannolis not compatible with node v23 out of the box #60

cephalization opened this issue Jan 11, 2025 · 1 comment

Comments

@cephalization
Copy link
Member

We should ensure that baked cannolis can run via node v23 out of the box.

Node v23 supports typescript natively, so it would be nice to have

It does not work currently because of the following error:

node phoenixDocumentRefinerCoreCanvas.ts 
(node:18792) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:18792) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/tony/repos/cannolis/phoenixDocumentRefinerCoreCanvas.ts is not specified and it doesn't parse as CommonJS.
Reparsing as ES module because module syntax was detected. This incurs a performance overhead.
To eliminate this warning, add "type": "module" to /Users/tony/repos/cannolis/package.json.
file:///Users/tony/repos/cannolis/phoenixDocumentRefinerCoreCanvas.ts:1
import { LLMConfig, resultsRun } from "@deablabs/cannoli-core";
         ^^^^^^^^^
SyntaxError: The requested module '@deablabs/cannoli-core' does not provide an export named 'LLMConfig'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:181:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:264:5)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:580:26)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:98:5)

Node.js v23.6.
@cephalization
Copy link
Member Author

Looks like we just need to add type in front of the LLMConfig import so that Node knows to strip it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant