Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item naming structure #26

Open
aliceingame opened this issue Apr 17, 2017 · 2 comments
Open

item naming structure #26

aliceingame opened this issue Apr 17, 2017 · 2 comments

Comments

@aliceingame
Copy link

Can I suggest to change the way that tool and mold are localized.

  1. I would suggest to use the model used for wood and stone type.

First line put the name of the tool / tool head / mold. In the second line, put the material.

That would use only one set of global lines for the material, and 3 lines by item type (mold/head/tool). That would even

The advantage would be to simplify the localization file (and the translation) and it would also give more unidormity to the way that the different type of material are displayed in the TFC2 items. This can also be
applied in the future to other type of items, like armor.

  1. For a set of items split in two ID, like the sapling and sapling2, to use a "global" localization string instead of the actually used "tile." string. It look like "global." is a new thing and it seems to be useful. This couls size down the "wood" section of the en_US file from 29 to 6 lines.

I would like to propose these changes in the early stage of development to make it easier for translators to start translating for the translation ressource pack.

Final note : for "sensible" lines like Bioxx and Kitty's birthday that were in TFC1, I would suggest to hardcode them (as I remember, at some point, someone changed Kitty's birthday for something else in one of the translation)

@emris
Copy link
Collaborator

emris commented Apr 17, 2017

Can you give an example, not really sure what you mean.

@aliceingame
Copy link
Author

Yes,

for point 1
in the .lang file, you have all the stone type set at "global." and not "tile."
For example : global.granite=Granite

Then the block themself are "tile." entry
For example : tile.rubble.name=Rubble

Then on the naming of the item/block ingame, there is two lines.

The item is effectively named "Rubble" or "Stone" or whatever stone item it is, but it does not state the type of stone. The type of stone if displayed on the second line, like this
image
(if that does not work, in game search for 1 wood type or stone type and you will see how the name of the item is on the two lines, in contrast with vanilla that only put the item name on a single line).

I think that this naming technique is called in this file (or I may totally be wrong, I do not really understand where the item name or localization line is set in the files) : TFC2/src/Common/com/bioxx/tfc2/items/itemblocks/ItemStone.java

The same idea could be applied to other items that have many variations. The item name would be more generic, and the material it is made of would be on the second line in grey.

For point 2

if you look at the sapling localization string, there is two lines, as there is two blocks to cover all the saplings, sapling and sapling2. Both have to be localized in order to have all the sapling with the right name in game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants