Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: (@vtmn/svelte): VtmnListItem component tabindex yields the value false #1489

Open
deviswamy1 opened this issue Mar 22, 2024 · 1 comment
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community Svelte 🟠 Related to Svelte components library

Comments

@deviswamy1
Copy link

Describe the bug
In the VtmnListItem component the anchor tag has a parameter tabindex which is validating with the value of disabled. If the disabled is true the tabindex is -1 but if the disabled is false the value of the tabindex is false instead 0. Please do the necessary changes

tabindex={disabled && -1}
Steps to reproduce
We can reproduce this in all decathlon search pages wherever the list is displayed

Expected behavior

Browsers affected

Version affected

@deviswamy1 deviswamy1 added the bug 🐛 Something isn't working label Mar 22, 2024
@Tlahey Tlahey added Svelte 🟠 Related to Svelte components library community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community labels Mar 22, 2024
@GURURAJ8
Copy link

Actually && doesn't work that way. You can use a ternary operator {disabled? 0:-1}, instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community Svelte 🟠 Related to Svelte components library
Projects
None yet
Development

No branches or pull requests

3 participants