Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best parameters for numbers of sampled rules and important rules #2

Open
csholder opened this issue Jun 10, 2021 · 3 comments
Open

Comments

@csholder
Copy link

The setup in your paper introduces 2000 sampled rules and 1000 important rules and I confuse about which dataset these parameters refer to. And the command lines given in README are also different with setups in you paper. Could you please release the details about the numbers of sampled rules and important rules during pre-training and training process? Thanks a lot!

@mnqu
Copy link
Collaborator

mnqu commented Jun 12, 2021

Thanks for your interest!
The current codes in the main branch give a simple implementation of RNNLogic, which is easier to use but the hyperparameters are different from those reported in the paper.
We have just published a new branch called torch, which corresponds to the implementation used in our experiment, and you could use the same hyperparameters as reported in the paper to run this model.
We will add more detailed README and comments for this new branch.

Thanks!
Meng

@csholder
Copy link
Author

Thank you for your reply, I will follow torch branch continuously. This work is really motivated to me, and I think it could reason facts with inductive reasoning method and deductive reasoning method simultaneously. I also focus on your other work and benefit a lot. Hope your better work!

Best wishes!
He Tao

@mnqu
Copy link
Collaborator

mnqu commented Jun 14, 2021

Thanks He! Also look forward to your work in this direction : )

Best regards!
Meng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants