Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility calendar switch buttons #11661

Merged

Conversation

littlesvensson
Copy link
Contributor

Fixes #11660

Description
As calendar is from a standalone library, the aria-labels were included using their built-in viewRender hook

This is a tiny enhancement that is not visible from outside but improves the accessibility of DefectDojo.

Before:
Screenshot 2025-01-27 at 12 14 04

After:
Screenshot 2025-01-27 at 10 30 22
Screenshot 2025-01-27 at 10 28 57
Screenshot 2025-01-27 at 10 29 12

@littlesvensson littlesvensson marked this pull request as ready for review January 27, 2025 11:28
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@dogboat dogboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mtesauro mtesauro merged commit 2e1042b into DefectDojo:dev Feb 6, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants