Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additonal considerations for water routing changes #141

Open
amoodie opened this issue Feb 18, 2021 · 0 comments
Open

additonal considerations for water routing changes #141

amoodie opened this issue Feb 18, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@amoodie
Copy link
Member

amoodie commented Feb 18, 2021

#133 will fix a number of problems with the water routing implementation, but doesn't completely fix the root issue though, which I believe is that sometimes very few parcels reach the boundary and the flow field kind of "dries up". This seems to happen in very large domains with very low sea-level rise (i.e., low accommodation), but can happen any time a restrictive configuration is reached (just by chance). I think a better/additional fix to consider may be to 1) continue routing water parcels until Np_water parcels have actually reached the boundary (or ~XX% of them anyway), or 2) somehow renormalize the parcels that did make it to the boundary to represent as though all Np_water parcels did reach the boundary. Things to consider...

@amoodie amoodie added the enhancement New feature or request label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant