Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make land initial condition into boundary condition? #179

Open
amoodie opened this issue Mar 30, 2021 · 0 comments
Open

make land initial condition into boundary condition? #179

amoodie opened this issue Mar 30, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@amoodie
Copy link
Member

amoodie commented Mar 30, 2021

Would it be acceptable to have all the land pixels increase by SLR each timestep? I.e., this would maintain the initial condition of the land cells as a boundary condition for the whole run.

Something like the below in finalize_timestep, where SLR is computed:

self.eta[self.cell_type == -2] += SLR

Needs to be verified that this works/makes sense. Purpose of this is mostly for DeltaMetrics, where the boundary condition would help ensure proper masking, but it makes results in pyDeltaRCM make more sense too, when there is significant SLR.

  • this should be a non-breaking change, because the land pixels don't have any water/sediment routing effect anyway
@amoodie amoodie added the enhancement New feature or request label Mar 30, 2021
@amoodie amoodie self-assigned this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant