-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can add a layer twice to the QGIS model #1683
Comments
It would perhaps be easier if we don't have this whole synchronization panel in the Model tab. The Layers panel should already tell enough should be the ultimate truth. "Add to QGIS" and "Remove from Dataset" should be removed and the Layers panel should be the geo package itself, no clone. |
I agree it would be easier, and the synchronization has caused me a fair bit of pain in the past. But:
This is not the case, and it can't be; the layers panel is not a clone. The Model tab is more like a clone of the Browser Panel: Presence in the layers panel makes QGIS aware of the layer. You can add or remove features, change the styling, etc., but you cannot delete for example. Deleting Layers requires access through the browser panel. The Layers panel is largely cosmetic: note that you can change the name of a Layers panel, but this does not update the name in the geopackage! It just gives you the freedom to display layers with a different name in your legend e.g. if you're making maps. Then, if you accidentally remove a layer from the Layers panel, it's still in the geopackage and it's still in the model; the data is not deleted. You can only get the layer back by going through the Browser panel and re-adding it to the Layers panel. Alternatively, you just re-open the TOML file and let the plugin do the work. I think it's worth considering to get rid of the "Add to QGIS" button, and introduce a different button called "Restore (from project)" -- see: #1687. That way, whenever you screw up your Layers panel, you can just reinstantiate it. Still, I think, you might as well keep "Add to QGIS" because the |
An initial QGIS test plan for the plugin. There are still some tests to be written. I have also performed all these tests and created quite some new reports. There is also a known issues page for all of Ribasim, as we have some things that simply don't work as expected. New issues: * #1678 * #1679 * #1681 * #1682 * #1683 * #1684 * #1685 * #1688 * #1689 * #1690 Fixes #320 --------- Co-authored-by: Martijn Visser <[email protected]>
Expected: the "Add to QGIS" button is disabled, because Edge is already in the model.
The text was updated successfully, but these errors were encountered: