Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated VERSION in install_kraken2.sh for v2.1.4 #920

Open
Simon-Brandt opened this issue Feb 24, 2025 · 1 comment
Open

Outdated VERSION in install_kraken2.sh for v2.1.4 #920

Simon-Brandt opened this issue Feb 24, 2025 · 1 comment

Comments

@Simon-Brandt
Copy link

In the latest release v2.1.4, the install_kraken.sh hasn't been updated to reflect the version number:

VERSION="2.1.3"

The Perl command

perl -pl -e 'BEGIN { while (@ARGV) { $_ = shift; ($k,$v) = split /=/, $_, 2; $H{$k} = $v } }'\
-e 's/#####=(\w+)=#####/$H{$1}/g' \
"KRAKEN2_DIR=$KRAKEN2_DIR" "VERSION=$VERSION" \
< "$file" > "$KRAKEN2_DIR/$(basename $file)"

should be the only one using that variable, replacing the placeholders in the following three scripts:

print "Kraken version #####=VERSION=#####\n";

print "Kraken version #####=VERSION=#####\n";

print "Kraken version #####=VERSION=#####\n";

This leads to a wrong version message:

$ kraken2 --version
Kraken version 2.1.3
Copyright 2013-2023, Derrick Wood ([email protected])

But since these commands just write to stdout, the normal functions of Kraken2 should not be affected.—In the case of my Docker container, I just set

RUN sed --in-place 's/VERSION="2.1.3"/VERSION="2.1.4"/' install_kraken2.sh

in the Dockerfile to replace the version number.

@ch4rr0
Copy link
Collaborator

ch4rr0 commented Feb 24, 2025

Thank you for reporting this. I will make sure that the version is updated moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants