Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Name for ILoggerAdapter and LoggerAdapter #261

Open
benrick opened this issue Oct 6, 2018 · 2 comments
Open

Better Name for ILoggerAdapter and LoggerAdapter #261

benrick opened this issue Oct 6, 2018 · 2 comments
Labels
code improvement Code-focused change. Lib update, refactoring, etc. good first issue Good for newcomers Hacktoberfest

Comments

@benrick
Copy link
Member

benrick commented Oct 6, 2018

It would be good to have a better name for ILoggerAdapter and LoggerAdapter in our codebase. They do act as wrappers around the Microsoft-provided ILogger and Logger, however, that's irrelevant to their use.

Anyone calling them should not care that they're "adapting" an interface.
@benrick benrick added good first issue Good for newcomers code improvement Code-focused change. Lib update, refactoring, etc. Hacktoberfest labels Oct 6, 2018
@twhite96
Copy link

twhite96 commented Oct 7, 2018

I can do this then. I'll fork and work on this today.

@kyledavi5
Copy link
Contributor

How does ILoggable and LogWriter sound?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code improvement Code-focused change. Lib update, refactoring, etc. good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benrick @kyledavi5 @twhite96