Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The lambda client hardcodes "us-east-1", but nuclearpond CLI asks for region in command line args, is this intentional? #3

Open
S4lt5 opened this issue May 9, 2023 · 2 comments
Open

The lambda client hardcodes "us-east-1", but nuclearpond CLI asks for region in command line args, is this intentional? #3

S4lt5 opened this issue May 9, 2023 · 2 comments

Comments

@S4lt5
Copy link

S4lt5 commented May 9, 2023

nuclearpond/pkg/lambda/lambda.go

Line 62 in 832cd11

Region: aws.String("us-east-1")},

@jonathanwalker
Copy link
Contributor

It is not and thanks for identifying that issue! Feel free to contribute or I can get around to this when I available to do so. Thanks!

@S4lt5
Copy link
Author

S4lt5 commented May 16, 2023

Sure! Right now I am trying to iron out all of the issues to see if this is overall works for us in general and when we've settled in I'll submit some PRs. I had to make a number of small changes to get it going with the latest nuclei in our AWS environ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@S4lt5 @jonathanwalker