Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeClimate's phpmd Complains About Underscore Prefix #10

Open
XedinUnknown opened this issue Aug 13, 2017 · 1 comment
Open

CodeClimate's phpmd Complains About Underscore Prefix #10

XedinUnknown opened this issue Aug 13, 2017 · 1 comment
Assignees
@XedinUnknown
Milestone
v0.1.1

Comments

@XedinUnknown
Copy link
Member

Even thought the phpmd config specifies that underscores in the beginning are allowed, CodeClimate still complains that underscore-prefixed names of protected methods are not camel-cased. It also says that this issue is both fixed and new, but this issue seems to be addressed in codeclimate/codeclimate-phpmd#41.

Apparently, it is now possible to disable individual checks. Perhaps the phpmd config is now ignored altogether.
@XedinUnknown XedinUnknown added this to the v0.1.1 milestone Aug 13, 2017
@XedinUnknown XedinUnknown self-assigned this Aug 13, 2017
@XedinUnknown
Copy link
Member Author

Apparently, it is only possible to disable the check for CamelCase method names. It doesn't seem possible to keep the check, but allow the underscore prefix from CodeClimate config. An issue has been filed with CodeClimate support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XedinUnknown XedinUnknown

Labels
None yet
Projects
None yet
Milestone
v0.1.1
Development

No branches or pull requests
1 participant
@XedinUnknown