You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ServiceList class is very useful for combining several services into a list. One of its useful abilities is to map them to keys that have meaning, rather than just the numeric index in the service definition list.
Unfortunatley, the mapping doesn't seem to work: it uses the olde resolveDeps(), despite useing the ResolveKeysCapableTrait.
Moreover, ResolveKeysCapableTrait#resolveKeys(), which should presulably be used to preserve the keys, uses resolveDeps() directly, without changing anything. And that, as we know, does not preserve keys.
Suggested Solution
It seems that the ResolveKeysCapableTrait was added in order to distinguish between key-knowing and key-agnostic resolution. Probably, just forgot to change ResolveKeysCapableTrait::resolveDeps() to use the key rather than [] (push).
The text was updated successfully, but these errors were encountered:
The
ServiceList
class is very useful for combining several services into a list. One of its useful abilities is to map them to keys that have meaning, rather than just the numeric index in the service definition list.Unfortunatley, the mapping doesn't seem to work: it uses the olde
resolveDeps()
, despiteuse
ing theResolveKeysCapableTrait
.Moreover,
ResolveKeysCapableTrait#resolveKeys()
, which should presulably be used to preserve the keys, usesresolveDeps()
directly, without changing anything. And that, as we know, does not preserve keys.Suggested Solution
It seems that the
ResolveKeysCapableTrait
was added in order to distinguish between key-knowing and key-agnostic resolution. Probably, just forgot to changeResolveKeysCapableTrait::resolveDeps()
to use the key rather than[]
(push).The text was updated successfully, but these errors were encountered: