Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

EventInterface's setter methods should return void #19

Closed
szepeviktor opened this issue Jun 21, 2021 · 3 comments
Closed

EventInterface's setter methods should return void #19

szepeviktor opened this issue Jun 21, 2021 · 3 comments

Comments

@szepeviktor
Copy link

Event's setter methods return the instance.

wp-events/src/Event.php

Lines 110 to 118 in feee39e

/**
* {@inheritdoc}
*/
public function setName($name)
{
$this->name = $name;
return $this;
}

Please advise.

@szepeviktor
Copy link
Author

Similar return type differences in WpEventManager versus EventManagerInterface.

@XedinUnknown
Copy link
Member

Heya, @szepeviktor! Thanks for pointing this out! This package is pending an update which will be released with a BC-breaking tag. The update will include PHP 8 support (#17), with all the relevant consequences. We will make sure that this is one of the things we do there.

@XedinUnknown
Copy link
Member

Closed in favour of #21.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants