Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDA incorrectly times out if it checks front absorber at a bad time #754

Open
olliesilvester opened this issue Jan 17, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@olliesilvester
Copy link
Contributor

olliesilvester commented Jan 17, 2025

I03's GDA has some logic to:

  1. Call Hyperion and wait 10 minutes for a response
  2. If no response is received after 10 minutes, check the front absorber
  3. If front absorber is closed then reset timer since it means the beam is bad. Otherwise, raise a timeout error

However, there are a few minutes where the front absorber is open but the beam isn't yet stable, so Hyperion is still waiting for XBPM to be happy. If GDA checks the front absorber in this time, it will timeout when we actually want it to reset the timer again. Neil says this isn't urgent and it's quite an edge case, however it's quite a quick fix so should do it.

Proposed solution:

  • If Hyperion times out and the front absorber is open, then reset the timeout. If it times out again and the absorber is still open, then error for real
@olliesilvester olliesilvester added the bug Something isn't working label Jan 17, 2025
@olliesilvester olliesilvester moved this to Candidates for Next Sprint in Hyperion Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Candidates for Next Sprint
Development

No branches or pull requests

1 participant