Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasional odd message from check_topup #777

Open
DominicOram opened this issue Jan 29, 2025 · 2 comments
Open

Occasional odd message from check_topup #777

DominicOram opened this issue Jan 29, 2025 · 2 comments

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Jan 29, 2025

We have seen an occasional log of:

[32m[I 250129 09:50:11.740 check_topup:67] 
                Exposure time of 0.0s below the threshold of 120s.
                Collection delayed until topup done.
                �[0m

This seems odd, why would the exposure be 0?

https://graylog.diamond.ac.uk/messages/graylog-daq-mx-hyperion_21/6e98dcd1-de26-11ef-ab61-32b1fc48808c

Acceptance Criteria

  • The log gives the correct exposure
@rtuck99
Copy link
Contributor

rtuck99 commented Jan 29, 2025

Seems like this is true only for gridscans, for rotations we report non-zero values.

do_fgs._wait_for_zocalo_to_stage_then_do_fgs() invokes

    yield from check_topup_and_wait_if_necessary(
        synchrotron,
        expected_images * exposure_sec_per_image,
        30.0,
    )

The total exposure time is obtained from expected_images * exposure_sec_per_image which are obtained from

expected_images = yield from bps.rd(grid_scan_device.expected_images)
exposure_sec_per_image = yield from bps.rd(detector.cam.acquire_time)

so it's likely that one of those things is zero

@DominicOram
Copy link
Contributor Author

DominicOram commented Jan 30, 2025

Added some logging which shows that expected_images is not getting set correctly. Issue looks to be that get_value on ExpectedImages is not getting called, changed to use create_hardware_backed_soft_signal on the beamline.

@DominicOram DominicOram moved this to Todo This Sprint in Hyperion Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo This Sprint
Development

No branches or pull requests

2 participants