Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data collection group comments for XRC #782

Open
DominicOram opened this issue Jan 30, 2025 · 1 comment
Open

Use data collection group comments for XRC #782

DominicOram opened this issue Jan 30, 2025 · 1 comment
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Contributor

Currently for data collection groups synchweb selects the comments from one of the two individual collections in the group. For XRC this means the comments only contain information on one of the 2D grids. There is a comment field for the group as a whole, which will be used after https://jira.diamond.ac.uk/browse/LIMS-1637. We should start filling this out in preparation containing information that relates to the whole grid e.g.

Acceptance Criteria

  • The comments in the data collection group for XRC contains a sensible comment
@DominicOram DominicOram added the good first issue Good for newcomers label Jan 30, 2025
@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Jan 30, 2025
@DominicOram
Copy link
Contributor Author

DominicOram commented Jan 30, 2025

Once this is done and the syncweb side is also done we can then remove the code added in #785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Candidates for Next Sprint
Development

No branches or pull requests

1 participant