Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear to a user that we're skipping collections after blank XRC #783

Closed
DominicOram opened this issue Jan 30, 2025 · 1 comment
Closed

Make it clear to a user that we're skipping collections after blank XRC #783

DominicOram opened this issue Jan 30, 2025 · 1 comment

Comments

@DominicOram
Copy link
Contributor

Now that we're skipping bad samples (#687) we should make this as clear as possible in the XRC comments so that a user knows what is going on.

Acceptance Criteria

  • When we get no diffraction for an XRC we put something like Diffraction not found, skipping sample. in the XRC comments
@DominicOram
Copy link
Contributor Author

Duplicate of #784 'cos GH is being weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DominicOram