From 0bf0d765c25a52173939641ca78ac6464d01ab0d Mon Sep 17 00:00:00 2001
From: Martin Indra <martin.indra@mgn.cz>
Date: Thu, 12 Oct 2023 12:51:18 +0200
Subject: [PATCH] WIP

---
 crates/combat/src/laser.rs                |  6 +-
 crates/combat/src/trail.rs                | 73 ++++++++++++++++++-----
 crates/messages/src/lib.rs                |  2 +-
 crates/messages/src/players/mod.rs        |  4 ++
 crates/messages/src/players/projectile.rs | 12 ++++
 crates/multiplayer/src/lib.rs             |  3 +-
 crates/multiplayer/src/messages.rs        |  1 +
 crates/multiplayer/src/playermsg.rs       | 10 +++-
 8 files changed, 91 insertions(+), 20 deletions(-)
 create mode 100644 crates/messages/src/players/projectile.rs

diff --git a/crates/combat/src/laser.rs b/crates/combat/src/laser.rs
index 8dda1648f..e4a5daf32 100644
--- a/crates/combat/src/laser.rs
+++ b/crates/combat/src/laser.rs
@@ -6,7 +6,7 @@ use parry3d::query::Ray;
 use crate::{
     health::{HealthSet, LocalUpdateHealthEvent},
     sightline::LineOfSight,
-    trail::TrailEvent,
+    trail::LocalLaserTrailEvent,
     AttackingSet,
 };
 
@@ -80,13 +80,13 @@ fn fire(
     mut fires: EventReader<LaserFireEvent>,
     sightline: LineOfSight,
     mut health: EventWriter<LocalUpdateHealthEvent>,
-    mut trail: EventWriter<TrailEvent>,
+    mut trail: EventWriter<LocalLaserTrailEvent>,
     mut start_sound: EventWriter<PlaySpatialAudioEvent>,
 ) {
     for fire in fires.iter() {
         let observation = sightline.sight(fire.ray(), fire.max_toi(), fire.attacker());
 
-        trail.send(TrailEvent::new(Ray::new(
+        trail.send(LocalLaserTrailEvent::new(Ray::new(
             fire.ray().origin,
             observation.toi() * fire.ray().dir,
         )));
diff --git a/crates/combat/src/trail.rs b/crates/combat/src/trail.rs
index cf311ce3d..a1849e563 100644
--- a/crates/combat/src/trail.rs
+++ b/crates/combat/src/trail.rs
@@ -11,7 +11,11 @@ use bevy::{
         },
     },
 };
-use de_core::{cleanup::DespawnOnGameExit, gamestate::GameState, state::AppState};
+use de_core::{
+    cleanup::DespawnOnGameExit, gamestate::GameState, gconfig::GameConfig, state::AppState,
+};
+use de_messages::{NetProjectile, ToPlayers};
+use de_multiplayer::{MessagesSet, NetRecvProjectileEvent, ToPlayersEvent};
 use parry3d::query::Ray;
 
 const TRAIL_LIFESPAN: Duration = Duration::from_millis(500);
@@ -22,20 +26,29 @@ pub(crate) struct TrailPlugin;
 impl Plugin for TrailPlugin {
     fn build(&self, app: &mut App) {
         app.add_plugins(MaterialPlugin::<TrailMaterial>::default())
-            .add_event::<TrailEvent>()
+            .add_event::<LocalLaserTrailEvent>()
+            .add_event::<LaserTrailEvent>()
             .add_systems(OnEnter(AppState::InGame), setup)
             .add_systems(OnExit(AppState::InGame), cleanup)
             .add_systems(
                 PostUpdate,
-                (spawn, update).run_if(in_state(GameState::Playing)),
+                (
+                    local_laser_trail
+                        .before(MessagesSet::SendMessages)
+                        .before(laser_trail),
+                    remote_laser_trail.before(laser_trail),
+                    laser_trail,
+                    update,
+                )
+                    .run_if(in_state(GameState::Playing)),
             );
     }
 }
 
 #[derive(Event)]
-pub(crate) struct TrailEvent(Ray);
+pub(crate) struct LocalLaserTrailEvent(Ray);
 
-impl TrailEvent {
+impl LocalLaserTrailEvent {
     /// Send this event to spawn a new trail. The trail will automatically fade
     /// out and disappear.
     ///
@@ -46,12 +59,11 @@ impl TrailEvent {
     pub(crate) fn new(ray: Ray) -> Self {
         Self(ray)
     }
-
-    fn ray(&self) -> &Ray {
-        &self.0
-    }
 }
 
+#[derive(Event)]
+struct LaserTrailEvent(Ray);
+
 #[derive(Resource)]
 struct MeshHandle(Handle<Mesh>);
 
@@ -104,12 +116,45 @@ impl Material for TrailMaterial {
     }
 }
 
-fn spawn(
+fn local_laser_trail(
+    config: Res<GameConfig>,
+    mut in_events: EventReader<LocalLaserTrailEvent>,
+    mut out_events: EventWriter<LaserTrailEvent>,
+    mut net_events: EventWriter<ToPlayersEvent>,
+) {
+    for event in in_events.iter() {
+        out_events.send(LaserTrailEvent(event.0));
+
+        if config.multiplayer() {
+            net_events.send(ToPlayersEvent::new(ToPlayers::Projectile(
+                NetProjectile::Laser {
+                    origin: event.0.origin.into(),
+                    direction: event.0.dir.into(),
+                },
+            )));
+        }
+    }
+}
+
+fn remote_laser_trail(
+    mut in_events: EventReader<NetRecvProjectileEvent>,
+    mut out_events: EventWriter<LaserTrailEvent>,
+) {
+    for event in in_events.iter() {
+        match **event {
+            NetProjectile::Laser { origin, direction } => {
+                out_events.send(LaserTrailEvent(Ray::new(origin.into(), direction.into())));
+            }
+        }
+    }
+}
+
+fn laser_trail(
     mut commands: Commands,
     mut materials: ResMut<Assets<TrailMaterial>>,
     time: Res<Time>,
     mesh: Res<MeshHandle>,
-    mut events: EventReader<TrailEvent>,
+    mut events: EventReader<LaserTrailEvent>,
 ) {
     for event in events.iter() {
         let material = materials.add(TrailMaterial::new(time.elapsed_seconds_wrapped()));
@@ -119,9 +164,9 @@ fn spawn(
                 mesh: mesh.0.clone(),
                 material,
                 transform: Transform {
-                    translation: event.ray().origin.into(),
-                    rotation: Quat::from_rotation_arc(Vec3::X, event.ray().dir.normalize().into()),
-                    scale: Vec3::new(event.ray().dir.norm(), 1., 1.),
+                    translation: event.0.origin.into(),
+                    rotation: Quat::from_rotation_arc(Vec3::X, event.0.dir.normalize().into()),
+                    scale: Vec3::new(event.0.dir.norm(), 1., 1.),
                 },
                 ..Default::default()
             },
diff --git a/crates/messages/src/lib.rs b/crates/messages/src/lib.rs
index b8440fe9d..93e3f9a40 100644
--- a/crates/messages/src/lib.rs
+++ b/crates/messages/src/lib.rs
@@ -4,7 +4,7 @@
 pub use game::{FromGame, JoinError, Readiness, ToGame};
 pub use players::{
     BorrowedFromPlayers, ChatMessage, ChatMessageError, EntityNet, FromPlayers, HealthDelta,
-    NetEntityIndex, ToPlayers, MAX_CHAT_LEN,
+    NetEntityIndex, NetProjectile, ToPlayers, MAX_CHAT_LEN,
 };
 pub use server::{FromServer, GameOpenError, ToServer};
 
diff --git a/crates/messages/src/players/mod.rs b/crates/messages/src/players/mod.rs
index ad452e130..57f12ac50 100644
--- a/crates/messages/src/players/mod.rs
+++ b/crates/messages/src/players/mod.rs
@@ -4,11 +4,13 @@ use de_types::{objects::ActiveObjectType, player::Player};
 pub use entity::{EntityNet, NetEntityIndex};
 pub use geom::{TransformNet, Vec2Net, Vec3Net, Vec4Net};
 pub use path::{PathError, PathNet};
+pub use projectile::NetProjectile;
 
 mod chat;
 mod entity;
 mod geom;
 mod path;
+mod projectile;
 
 /// Messages to be sent by a player/client or occasionally the game server to
 /// other players.
@@ -85,6 +87,8 @@ pub enum ToPlayers {
         entity: EntityNet,
         delta: HealthDelta,
     },
+    /// Some kind of projectile was spawned (e.g. rocket, laser trail).
+    Projectile(NetProjectile),
 }
 
 #[derive(Debug, Encode, Decode)]
diff --git a/crates/messages/src/players/projectile.rs b/crates/messages/src/players/projectile.rs
new file mode 100644
index 000000000..63ef446f3
--- /dev/null
+++ b/crates/messages/src/players/projectile.rs
@@ -0,0 +1,12 @@
+use bincode::{Decode, Encode};
+
+use crate::players::Vec3Net;
+
+#[derive(Clone, Copy, Debug, Encode, Decode)]
+pub enum NetProjectile {
+    Laser {
+        origin: Vec3Net,
+        /// End of the trail lies at `origin + direction`.
+        direction: Vec3Net,
+    },
+}
diff --git a/crates/multiplayer/src/lib.rs b/crates/multiplayer/src/lib.rs
index 3ca6eb6ce..e686a1c57 100644
--- a/crates/multiplayer/src/lib.rs
+++ b/crates/multiplayer/src/lib.rs
@@ -25,7 +25,8 @@ pub use crate::{
     netstate::NetState,
     playermsg::{
         GameNetSet, NetEntities, NetEntityCommands, NetRecvDespawnActiveEvent, NetRecvHealthEvent,
-        NetRecvSetPathEvent, NetRecvSpawnActiveEvent, NetRecvTransformEvent,
+        NetRecvProjectileEvent, NetRecvSetPathEvent, NetRecvSpawnActiveEvent,
+        NetRecvTransformEvent,
     },
 };
 use crate::{netstate::NetStatePlugin, network::NetworkPlugin};
diff --git a/crates/multiplayer/src/messages.rs b/crates/multiplayer/src/messages.rs
index 8b7d7ff8d..481e58e63 100644
--- a/crates/multiplayer/src/messages.rs
+++ b/crates/multiplayer/src/messages.rs
@@ -144,6 +144,7 @@ impl ToMessage for ToPlayersEvent {
             ToPlayers::SetPath { .. } => Reliability::SemiOrdered,
             ToPlayers::Transform { .. } => Reliability::Unreliable,
             ToPlayers::ChangeHealth { .. } => Reliability::SemiOrdered,
+            ToPlayers::Projectile(_) => Reliability::Unreliable,
         }
     }
 
diff --git a/crates/multiplayer/src/playermsg.rs b/crates/multiplayer/src/playermsg.rs
index 3a8396827..7a058baf0 100644
--- a/crates/multiplayer/src/playermsg.rs
+++ b/crates/multiplayer/src/playermsg.rs
@@ -4,7 +4,7 @@ use bevy::{
     prelude::*,
 };
 use de_core::{gconfig::GameConfig, schedule::PreMovement, state::AppState};
-use de_messages::{EntityNet, NetEntityIndex, ToPlayers};
+use de_messages::{EntityNet, NetEntityIndex, NetProjectile, ToPlayers};
 use de_types::{objects::ActiveObjectType, path::Path, player::Player};
 
 use crate::messages::{FromPlayersEvent, MessagesSet};
@@ -19,6 +19,7 @@ impl Plugin for PlayerMsgPlugin {
             .add_event::<NetRecvHealthEvent>()
             .add_event::<NetRecvTransformEvent>()
             .add_event::<NetRecvSetPathEvent>()
+            .add_event::<NetRecvProjectileEvent>()
             .add_systems(OnEnter(AppState::InGame), setup)
             .add_systems(OnExit(AppState::InGame), cleanup)
             .add_systems(
@@ -166,6 +167,9 @@ impl NetRecvSetPathEvent {
     }
 }
 
+#[derive(Event, Deref)]
+pub struct NetRecvProjectileEvent(NetProjectile);
+
 #[derive(SystemParam)]
 pub struct NetEntities<'w> {
     config: Res<'w, GameConfig>,
@@ -356,6 +360,7 @@ fn recv_messages(
     mut path_events: EventWriter<NetRecvSetPathEvent>,
     mut transform_events: EventWriter<NetRecvTransformEvent>,
     mut health_events: EventWriter<NetRecvHealthEvent>,
+    mut projectile_events: EventWriter<NetRecvProjectileEvent>,
 ) {
     for input in inputs.iter() {
         match input.message() {
@@ -404,6 +409,9 @@ fn recv_messages(
 
                 health_events.send(NetRecvHealthEvent::new(local, delta.into()));
             }
+            ToPlayers::Projectile(projectile) => {
+                projectile_events.send(NetRecvProjectileEvent(*projectile));
+            }
             _ => (),
         }
     }