Bug:Sends access token via Sec-Websocket-Protocol

[waldiTM]

Environment:

• OS: iPadOS 18.1.1
• IceCubesApp version: 1.11.2

Description

Ice Cubes sends the access token for the streaming API via the Sec-Websocket-Protocol header. The Mastodon documentation of the streaming API does not document this way of use. And this header is not considered sensitive, so often logged.

The documented way to do auth against the streaming API is to use the access_token query parameter.

The standard Authorization header is implemented as well for the streaming API, but not documented.

Related Issues

• Search that this bugs don't already exist before creating it.

[waldiTM]

I don't know Swift, but the relevant code seems to be Client.makeWebSocketTask. It clearly shows the setup of the protocols parameter.