Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SecondaryMap instead of SlotMap #708

Open
test3211234 opened this issue Sep 2, 2024 · 0 comments
Open

Use SecondaryMap instead of SlotMap #708

test3211234 opened this issue Sep 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@test3211234
Copy link

What problem does this solve or what need does it fill?

Since it's additional data, I thought SecondaryMap should be used instead of SlotMap here:

https://github.com/DioxusLabs/taffy/blob/9915b967e9809dc57f210de8fe5f7510e66806d6/src/tree/taffy_tree.rs#L137C5-L145C50

What solution would you like?

Use SecondaryMap. Look at Floem:

https://github.com/lapce/floem/blob/919a62c51c208cf9401edd78a08849d5629bb442/src/view_storage.rs#L15C5-L17C61

What alternative(s) have you considered?

N/A

Additional context

N/A

@test3211234 test3211234 added the enhancement New feature or request label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant