Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behaviour when attempting to skip dwell time on the last stop of depot schedule of a train #1

Open
BDark000 opened this issue Nov 9, 2023 · 1 comment

Comments

@BDark000
Copy link

BDark000 commented Nov 9, 2023

(Maybe resolve/update after MTR 4.0.0 is wiser choice but I just drop this down when memory is still fresh)
Expected:

  • The train continues next schedules without opening the doors on its first and last stop

Actual:

  • After the train arrives at the last stop, it disappears and all the pids along all stops it serves shows a fake departure with arriving time = 0s

How to reproduce:

  1. Create a route that can allow repeat instructions forever
  2. Create a depot and siding to make trains run on that route and repeating instructions forever
  3. Run /train SkipDwell when the train departs from the second last stop in the instructions
  4. Above actual results appear after the train arrives at the last stop also the first stop of next schedule
@Kenny-Hui
Copy link
Member

I'll probably leave that for 4.0.0, if this ever gets ported that is...
All TransitManager does is set the Elapsed Dwell to the Total Dwell and nothing more than that, so technically it's MTR not handling edge cases properly (But we are the one breaking things aren't we?)

Either way 4.0.0 has lots of changes, and there's a good chance it may no longer be a problem (Or the problem worsened), but we'll see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants