Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commemoration comment line wrong when 09-08 vespers falls on a Saturday #3465

Closed
fiapps opened this issue Dec 6, 2023 · 1 comment · Fixed by #3467
Closed

Commemoration comment line wrong when 09-08 vespers falls on a Saturday #3465

fiapps opened this issue Dec 6, 2023 · 1 comment · Fixed by #3467

Comments

@fiapps
Copy link
Contributor

fiapps commented Dec 6, 2023

Oddly, with the 1960 rubrics, when September 8 is a Saturday, Vespers are now titled "In Nativitate Beatæ Mariæ Virginis ~ II. classis" with "Commemoratio: In Nativitate Beatæ Mariæ Virginis". At c044962 (before PR #3438 was merged), the commemoration was correctly identified with "Commemoratio: Dominica XVI Post Pentecosten II. Septembris".

The commemoration actually made in the office is correct, it's just the comment line that's wrong.

September 8 was a Saturday in 2018, and won't be again until 2029, but the underlying bug may affect other offices.

@APMarcello3
Copy link
Contributor

APMarcello3 commented Dec 6, 2023

I would also add that grammatically, there should probably be a colon after "Commemoratio" if the Latin title of the commemoration is not going to appear in the genitive case but will remain in the nominative. I refer specifically to the Lauds & Vespers commemorations on Advent ferias.

FAJ-Munich added a commit to FAJ-Munich/divinum-officium that referenced this issue Dec 6, 2023
Grammatical correction; no colon for Latin && Sancti only
FAJ-Munich added a commit to FAJ-Munich/divinum-officium that referenced this issue Dec 6, 2023
Fixing commemoration headline on Saturdays (all rubrics) and Sundays Vespers (pre-1960) when the Sunday is giving way in concurrence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants