Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(clean code) base hash not used as data.text does not have a base column #4115

Closed
d4h0y0sr opened this issue Oct 18, 2024 · 1 comment
Closed

Comments

@d4h0y0sr
Copy link
Contributor

Directorium.pm has an issue because data.txt does not have a base column.

sub load_data_data() function init the _data hash:

$_data{$ver}{base} = $base;

as data.txt does not have a base column, thus this value is always empty.

this affects get_kalendar, get_transfer, get s_transfer and get_tempora, as they are always returning '' and last line is never reach:

  my $ver = $_data{$version}{base};
  return '' unless $ver;
  return get_kalendar($ver, $day);
@FAJ-Munich
Copy link
Contributor

The feature is in the code for 10 months now but not yet used by the official repository; it might well be used by some private forks.
In view of #423, it should remain part of the code.

@FAJ-Munich FAJ-Munich closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants