Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API Irregularities Between dstats.distrib and dstats.random #29

Open
jmh530 opened this issue Aug 29, 2017 · 1 comment
Open

Fix API Irregularities Between dstats.distrib and dstats.random #29

jmh530 opened this issue Aug 29, 2017 · 1 comment

Comments

@jmh530
Copy link

jmh530 commented Aug 29, 2017

I have noticed some irregularities in the API for dstats.distrib and dstats.random.

  1. Most of the inverse CDF functions are f(p, param), but some are f(param, p). These are the two that jump out as being opposite of the others: invChiSquareCDFR, invFisherCDFR

  2. The names in dstats.random do not match the names in dstats.distrib in some cases. These three jump out: rLogNorm, rNorm, rStudentT

  3. Excluding the first time (which obviously should be different), the type signature of invBinomialCDF does not match that of binomialCDF. Contrasting invBinomialCDF and binomialCDF, n is uint in one and ulong in another.

@jmh530
Copy link
Author

jmh530 commented Aug 29, 2017

  1. Hypergeometric in dstats.distrib are long, but are int in dstats.random. There is a similar issue with rBinomial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant