From 27a505c92235462750fe4d5f576f0e2f820c380a Mon Sep 17 00:00:00 2001 From: Lauren Tan Date: Thu, 16 Apr 2015 17:02:03 -0400 Subject: [PATCH 1/4] Updated readme with link to demo --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 635879c6..36889d76 100644 --- a/README.md +++ b/README.md @@ -7,6 +7,10 @@ This `ember-cli` addon adds a simple, highly performant Ember Mixin to your app. This software will not be ready for production use until `1.0.0`. +## Demo +- App: http://development.ember-in-viewport-demo.divshot.io/ +- Source: https://github.com/poteto/ember-in-viewport-demo + ## Usage Usage is simple. First, add the mixin to your `Component`: From ef1de003999e7f6350858b3c97b92661b3babcd0 Mon Sep 17 00:00:00 2001 From: Lauren Tan Date: Fri, 17 Apr 2015 10:16:12 -0400 Subject: [PATCH 2/4] Updated readme about `viewportUseRAF` --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index 36889d76..16f64754 100644 --- a/README.md +++ b/README.md @@ -58,6 +58,12 @@ export default Ember.Component.extend(InViewportMixin, { }); ``` +- `viewportUseRAF: boolean` + + Default: Depends on browser + + As it's name suggests, if this is `true`, the mixin will use `requestAnimationFrame` instead of the Ember run loop. Unless you want to force enabling or disabling this, you won't need to override this option. + - `viewportSpy: boolean` Default: `false` From 8df26dd332b0d94b02f799911a4b9f7d63fc3b61 Mon Sep 17 00:00:00 2001 From: Lauren Tan Date: Fri, 17 Apr 2015 11:07:13 -0400 Subject: [PATCH 3/4] Fixed incorrect top and left tolerance calculations --- addon/utils/is-in-viewport.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/utils/is-in-viewport.js b/addon/utils/is-in-viewport.js index 19410218..0208263c 100644 --- a/addon/utils/is-in-viewport.js +++ b/addon/utils/is-in-viewport.js @@ -20,8 +20,8 @@ export default function isInViewport(boundingClientRect={}, height=0, width=0, t } = tolerances; return ( - (top - topTolerance) >= 0 && - (left - leftTolerance) >= 0 && + (top + topTolerance) >= 0 && + (left + leftTolerance) >= 0 && (bottom - bottomTolerance) <= height && (right - rightTolerance) <= width ); From 790a9887bb7657c314a7d970fd7f419d0780fe81 Mon Sep 17 00:00:00 2001 From: Lauren Tan Date: Fri, 17 Apr 2015 11:10:03 -0400 Subject: [PATCH 4/4] Version bump to 0.2.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5e9360ed..e0b055bd 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ember-in-viewport", - "version": "0.2.0", + "version": "0.2.1", "description": "Detect if an Ember View or Component is in the viewport @ 60FPS", "directories": { "doc": "doc",