Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Database and Schema Updates - Filled filaments, temperature ranges, material field, alloy codes. #19

Closed
YanceyA opened this issue May 22, 2024 · 3 comments

Comments

@YanceyA
Copy link
Contributor

YanceyA commented May 22, 2024

In the work to create entries for 3DXTECH filaments i ran across a few bits which could be addressed. I fully understand that making the database too complex is not desirable or actually beneficial to end users.

  • 3DXTECH use temperature ranges for extruder and bed temp. The JSON schema only allows for a single integer. It would be nice to be able to input two values indicating a temperature range recommended by the manufacturer. Alternatively we could have a min and max values for extruder/bed (less preferred I think as that creates two new fields and begs the questions of what to enter when only a single value is given by the manufacturer).

This probably doesn't matter as users set their own print temps through the slicer config and filament calibrations. For 3DXTECH filaments I just averaged the two band values. But this is not exactly correct, so it bothered me a little bit 🥲

  • I think we need a solution to deal with filled filaments. My initial suggestion is simply an optional "fill" parameter that is "null, glass fiber, carbon fiber". The material name could then be NAME {color_name} {fill}. Most of the 3DXTECH entries have fill material and that is important to call out. They way I implemented it feels a bit clunky have it as text "Carbon Fiber" in the name.

Also some guidance on how to deal with the material field text with regards to fill and alloys would be helpful:

  • For two filaments ABS and Carbon Fiber ABS should they both have material as ABS or should they be ABS and ABS-CF. My suggestion is to use the later as they are two difference materials and conforms to ISO 1043 marking standard.

  • In general polymer alloys should be designated as PC+ABS and not PC/ABS to conform to ISO 1043 marking standards. So a blend with fill would be PC+ABS-CF or PC+ABS-GF. This gives us a basis of why to do it this way.

@Donkie
Copy link
Owner

Donkie commented May 23, 2024

I could add new fields called e.g. "extruder_temp_range" and then you can either specify a single value or use this new field to specify a range. That should solve it for all use cases.

Yes, a fill field is a good idea. You can submit a PR to add that to the schema if you want. I dont think you need to add {fill} to the filament name though since that should be evident from the material name, where I agree we should go with as you said e.g. ABS-CF.

I also agree with your blend marking there. Good to keep it consistent.

StuSerious added a commit to StuSerious/SpoolmanDB that referenced this issue May 23, 2024
@StuSerious
Copy link
Contributor

I've drafted an idea in #21

StuSerious added a commit to StuSerious/SpoolmanDB that referenced this issue May 23, 2024
StuSerious added a commit to StuSerious/SpoolmanDB that referenced this issue May 23, 2024
StuSerious added a commit to StuSerious/SpoolmanDB that referenced this issue May 23, 2024
Donkie added a commit that referenced this issue May 28, 2024
@Donkie
Copy link
Owner

Donkie commented May 28, 2024

I think this is fully implemented now by Stu's PR

@Donkie Donkie closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants