Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update to Fody Version 2 #15

Closed
SimonCropp opened this issue Apr 23, 2017 · 8 comments
Closed

Update to Fody Version 2 #15

SimonCropp opened this issue Apr 23, 2017 · 8 comments

Comments

@SimonCropp
Copy link
Contributor

Fody Version 2 is out and you will need to do an update for your addin to be usable with it

Specifically:

  • Update to the newest Fody.Cecil nuget
  • Change the min dependency range for Fody to be at least 2.0

Please ping me if u need help

@Dresel
Copy link
Owner

Dresel commented May 11, 2017

Sorry for my late reply. Will update asap. Thanks for mentioning.

@meledictas
Copy link

Hi,

Latest release from nuget doesn't seem to work. I'm using Visual Studio Community 2017 version 15.2. Following below steps:

  1. Install MethodCache.Fody via Nuget (MethodCache.Fody.1.5.0 is installed)
  2. Add in the Weavers.xml
  3. Try build and got Could not load file or assembly 'Microsoft.Build.Framework, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
  4. Try upgrade Fody to version 2.0.9 and got error MSBUILD : error : Fody: The weaver assembly 'MethodCache.Fody, Version=1.5.0.0, Culture=neutral, PublicKeyToken=null' references an out of date version of Mono.Cecil.dll (cecilReference.Version). At least version 0.10 is expected. The weaver needs to add a NuGet reference to FodyCecil version 2.0.

Downgrade Fody to version 1.29.4.0 then can build successfully.

Thanks,

@Dresel
Copy link
Owner

Dresel commented May 31, 2017

@SimonCropp

MethodCache.Fody 1.5.1 now defines Fody < 2.0.0. Since NuGet Client installs Fody 1.28.3 it breaks on VS 2017. Any thoughts on this? Should I set the minimum version to 1.29.1?

MethodCache.Fody 2.0.0-alpha1 now references Mono.Cecil > 0.10 and should be compatible with Fody >= 2.0.0.

Not related to this issue, but might I ask you a different question? Now that Fody supports .NET Standard what will be necessary to support this? I guess it does not only affect the MethodCache.Attributes PCL but also the Weaver assembly itself (e.g. ReferenceFinder.cs)?

@meledictas:

You can try

Install-Package MethodCache.Fody -Version 2.0.0-alpha1

if you want to use a newer version of Fody.

@shtse8
Copy link

shtse8 commented Feb 18, 2018

any updates for the stable release?

@Dresel
Copy link
Owner

Dresel commented Feb 19, 2018

Does 2.0.0-alpha1 not work for you?

@shtse8
Copy link

shtse8 commented Feb 19, 2018

It works.
I am choosing between Fody vs P# for caching and propertynotify.
I like Fody very much, but I can't find a good caching active package.
So I want to know when will the stable version be released? or is this github still active?
Thanks for your contribution.

@Dresel
Copy link
Owner

Dresel commented Feb 19, 2018

I'm not actively adding new features if it is that what you mean, so that is why this repo might look inactive. But when bug requests come in, I'm usually going to fix them asap.

This version is stable as far as I know (at least there are no open issues if #14 is considered as feature request), so the only thing I could do is changing the version number from 2.0.0-alpha1 to 2.0.0.

@shtse8
Copy link

shtse8 commented Feb 19, 2018

@Dresel That's great and what I want.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants