From 5b6304d8ba57339a193f3388d4eb7ea3feb7a75f Mon Sep 17 00:00:00 2001 From: ked4ma Date: Wed, 30 Aug 2023 03:05:30 +0900 Subject: [PATCH] update comment --- .../component/TimetableItemDetailScreenTopAppBar.kt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/feature/sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/component/TimetableItemDetailScreenTopAppBar.kt b/feature/sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/component/TimetableItemDetailScreenTopAppBar.kt index 5b3ae4364..813ad4c9c 100644 --- a/feature/sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/component/TimetableItemDetailScreenTopAppBar.kt +++ b/feature/sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/component/TimetableItemDetailScreenTopAppBar.kt @@ -108,9 +108,10 @@ private fun ResizeableText( style = styles[styleIndex], modifier = Modifier .padding(end = 16.dp) - // title heights of LargeTopAppBar will be used `TopAppBarLargeTokens.ContainerHeight` and `TopAppBarSmallTokens.ContainerHeight`. - // these are internal values in material3. - // so, set max height as constant dp. (Large - Small) + // title heights of LargeTopAppBar will use `TopAppBarLargeTokens.ContainerHeight`, `TopAppBarSmallTokens.ContainerHeight` and `scroll offset`. + // because of this, this height become taller than our expectation. + // we want to fix max height, but `ContainerHeight`s are internal values in material3. + // so set as constant dp. (Large - Small) .heightIn(max = 88.dp), ) }