Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'array too long' message by giving the parameter letter #907

Closed
dc42 opened this issue Sep 11, 2023 · 2 comments
Closed

Improve 'array too long' message by giving the parameter letter #907

dc42 opened this issue Sep 11, 2023 · 2 comments
Assignees
Labels
enhancement Additional functionality, performance or other feature request
Milestone

Comments

@dc42
Copy link
Collaborator

dc42 commented Sep 11, 2023

The 'array too long' message would be more helpful if the parameter letter whose value is being parsed was included in the error message. See for example https://forum.duet3d.com/topic/33513/startup-error-on-rrf-3-5-0-rc1.

@dc42 dc42 added the enhancement Additional functionality, performance or other feature request label Sep 11, 2023
@dc42 dc42 added this to the 3.5.1 milestone Sep 11, 2023
@dc42 dc42 self-assigned this Sep 11, 2023
@dc42 dc42 modified the milestones: 3.5.1, 3.5.2 Apr 21, 2024
@dc42
Copy link
Collaborator Author

dc42 commented May 18, 2024

The exception that gets thrown when this error occurs accepts only one parameter. Currently we pass the maximum length as the parameter. Do we want the message to include the parameter letter instead of the maximum length?

@dc42
Copy link
Collaborator Author

dc42 commented May 22, 2024

Changed in 3.5-dev so that the error message reports the parameter letter instead of the maximum length when in standalone mode.

@dc42 dc42 closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional functionality, performance or other feature request
Projects
None yet
Development

No branches or pull requests

1 participant