Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return full code reply via HTTP rr_reply code for corresponding rr_gcode calls #925

Open
chrishamm opened this issue Oct 26, 2023 · 0 comments
Labels
enhancement Additional functionality, performance or other feature request
Milestone

Comments

@chrishamm
Copy link
Collaborator

@T3P3 requested a better rr_reply HTTP interface which returns the matching G-code reply of a previously issued rr_gcode request. At the moment DWC replies can be duplicated (and logged multiple times, e.g. in a macro when dealing with M291/M292 and echo calls) which makes code reply parsing in plugins more difficult and has the potential to confuse users.

Possibly rr_gcode could return the next sequence number and rr_reply could accept that previously returned sequence number to return only a subset of the buffered G-code reply. M122 and other codes that do subsequent Platform::Message(F) would need special handling, though.

@chrishamm chrishamm added the enhancement Additional functionality, performance or other feature request label Oct 26, 2023
@chrishamm chrishamm added this to the 3.6.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional functionality, performance or other feature request
Projects
None yet
Development

No branches or pull requests

1 participant