Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: use a single pack size cmake setting #6991

Open
bartgol opened this issue Feb 11, 2025 · 0 comments
Open

EAMxx: use a single pack size cmake setting #6991

bartgol opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
CMake build system code cleanup EAMxx PRs focused on capabilities for EAMxx

Comments

@bartgol
Copy link
Contributor

bartgol commented Feb 11, 2025

Other than SCREAM_PACK_SIZE we have SCREAM_SMALL_PACK_SIZE and SCREAM_POSSIBLY_NO_PACK_SIZE. The last two are never used. I mean, they are used to set the homonymous macros, but a) the macro SCREAM_POSSIBLY_NO_PACK_SIZE is never used in EAMxx, and b) our mach files never set SCREAM_SMALL_PACK_SIZE smaller than SCREAM_PACK_SIZE.

Supporting all these different options for no practical reason seems like a waste. The complexity of the code is larger, when we could get away with just one (app-wide) pack size. Of course, particular files can always something like

constexpr int MY_SMALL_PACK_SIZE = SCREAM_PACK_SIZE>1 ? SCREAM_PACK_SIZE / 2 : 1;

but keeping a cmake vars for something that is never configured differently from the default, seems pointless.

@jgfouca you were involved in the seminal pack work, so your opinion is very important here. Other devs can weigh in too, of course.

@bartgol bartgol added CMake build system code cleanup EAMxx PRs focused on capabilities for EAMxx labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake build system code cleanup EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Development

No branches or pull requests

2 participants