You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Other than SCREAM_PACK_SIZE we have SCREAM_SMALL_PACK_SIZE and SCREAM_POSSIBLY_NO_PACK_SIZE. The last two are never used. I mean, they are used to set the homonymous macros, but a) the macro SCREAM_POSSIBLY_NO_PACK_SIZE is never used in EAMxx, and b) our mach files never set SCREAM_SMALL_PACK_SIZE smaller than SCREAM_PACK_SIZE.
Supporting all these different options for no practical reason seems like a waste. The complexity of the code is larger, when we could get away with just one (app-wide) pack size. Of course, particular files can always something like
Other than
SCREAM_PACK_SIZE
we haveSCREAM_SMALL_PACK_SIZE
andSCREAM_POSSIBLY_NO_PACK_SIZE
. The last two are never used. I mean, they are used to set the homonymous macros, but a) the macroSCREAM_POSSIBLY_NO_PACK_SIZE
is never used in EAMxx, and b) our mach files never setSCREAM_SMALL_PACK_SIZE
smaller thanSCREAM_PACK_SIZE
.Supporting all these different options for no practical reason seems like a waste. The complexity of the code is larger, when we could get away with just one (app-wide) pack size. Of course, particular files can always something like
but keeping a cmake vars for something that is never configured differently from the default, seems pointless.
@jgfouca you were involved in the seminal pack work, so your opinion is very important here. Other devs can weigh in too, of course.
The text was updated successfully, but these errors were encountered: