Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set track_avg_cnt: true by default #2922

Closed
mahf708 opened this issue Jul 26, 2024 · 4 comments
Closed

set track_avg_cnt: true by default #2922

mahf708 opened this issue Jul 26, 2024 · 4 comments

Comments

@mahf708
Copy link
Contributor

mahf708 commented Jul 26, 2024

          >@AaronDonahue should we maybe turn on avg count tracking automatically for this diag? Or, more in general, for any field that can have a certain extra data set in the header (something like "can_have_invalid_data" or something)?

Yes, I think we would want to do that rather than have users try to figure out why some fields are nan, or otherwise bad values.

Originally posted by @AaronDonahue in #2916 (comment)

@mahf708
Copy link
Contributor Author

mahf708 commented Jul 26, 2024

Also, note to fix this in cosp:

// If not updating COSP statistics, set these to ZERO; this essentially weights
// the ISCCP cloud properties by the sunlit mask. What will be output for time-averages
// then is the time-average mask-weighted statistics; to get true averages, we need to
// divide by the time-average of the mask. I.e., if M is the sunlit mask, and X is the ISCCP
// statistic, then
//
// avg(X) = sum(M * X) / sum(M) = (sum(M * X)/N) / (sum(M)/N) = avg(M * X) / avg(M)
//
// TODO: mask this when/if the AD ever supports masked averages

And maybe another issue in cosp: E3SM-Project/E3SM#5495 (comment)

@mahf708
Copy link
Contributor Author

mahf708 commented Jul 26, 2024

@AaronDonahue + @bartgol: moving the discussion here.

Is there any downside of setting the default track_avg_cnt: true for everything? No need to special-case it, just turn it on everywhere?

@bartgol
Copy link
Contributor

bartgol commented Jul 26, 2024

Having track_avg_cnt: true by default implies that we need to accumulate and write to file a few more fields. While the number of extra fields may not be remarkable, for use cases where we split output into many files (like prod runs often do), it may add up to a non negligible amount of extra output. As such, I am inclined to have IO detect whether or not track_avg_cnt should be on, and remove it from the yaml file options.

@mahf708
Copy link
Contributor Author

mahf708 commented Aug 7, 2024

Closing this as it is an item in #2938, so no need for a separate issue.

@mahf708 mahf708 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants