Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I/O possible check to implement: Make sure no two output streams have the exact same name #3020

Open
AaronDonahue opened this issue Sep 30, 2024 · 6 comments
Assignees
Labels
Error Check Potential condition to add an error check for help wanted Extra attention is needed I/O

Comments

@AaronDonahue
Copy link
Contributor

I recently helped troubleshoot a case where someone couldn't run their simulation because I/O gave an error about redefining the time dimension when it already existed. It took us awhile to figure out it had nothing to do w/ the time dimension in the file, instead, they had two output streams with the same filename prefix and frequency, etc. So ultimately, two output streams attempting to access the same file.

We could implement a check in the driver that quickly checks all OM that have been setup to ensure no two share a name, if so, throw an error that is human readable and makes it easy to fix.

@AaronDonahue AaronDonahue added I/O Error Check Potential condition to add an error check for labels Sep 30, 2024
@AaronDonahue AaronDonahue self-assigned this Sep 30, 2024
@bartgol
Copy link
Contributor

bartgol commented Sep 30, 2024

This check is better suited for buildnml phase.

@AaronDonahue
Copy link
Contributor Author

oh yes, that would be a fantastic place to put it. Quick question on that, would be able to support cases where the filename_prefix was the same but the averaging_type was different? Which in EAMxx would be fine since the filenames would ultimately be different.

@mahf708
Copy link
Contributor

mahf708 commented Sep 30, 2024

xref #3001 and #2981

@bartgol
Copy link
Contributor

bartgol commented Sep 30, 2024

Also check #2986 .

@AaronDonahue I don't get your question. We already support that. The PR i linked is fixing a bug related to restart for that precise case.

@AaronDonahue
Copy link
Contributor Author

huh, strange. Then I'm not sure why Hassan was hitting an error which was resolved when he changed prefixes. I can close this issue and investigate more on Hassan's side.

@mahf708
Copy link
Contributor

mahf708 commented Oct 1, 2024

This issue is valid. Let's keep it open for now. We will triage...

@mahf708 mahf708 reopened this Oct 1, 2024
@mahf708 mahf708 added the help wanted Extra attention is needed label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Check Potential condition to add an error check for help wanted Extra attention is needed I/O
Projects
None yet
Development

No branches or pull requests

3 participants