Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot assign value 15 to descriptor 020011 #63

Open
vsouvan opened this issue Apr 19, 2020 · 2 comments
Open

cannot assign value 15 to descriptor 020011 #63

vsouvan opened this issue Apr 19, 2020 · 2 comments

Comments

@vsouvan
Copy link
Collaborator

vsouvan commented Apr 19, 2020

The bufr encoder reject the value of 15 as "out of range" for the descriptor 20011.
Even if 20011 is 4 bits width. The WMO 306 vI2 Code Flag document clearly specify code 15 as valid and signify "Cloud cover is indiscernible for reasons other than fog or other meteorological
phenomena, or observation is not made"


Imported from Launchpad using lp2gh.

@vsouvan
Copy link
Collaborator Author

vsouvan commented Apr 19, 2020

(by chris-beauregard)
Does

bufr_value_get_int32( bv, bufr_missing_int() );

show the same issue? Because if not, it seems more like a problem of the code generator trying to blindly follow the documentation instead of realizing that "15" is just a fancy way to say "missing".

It might be necessary for the encoder to realize that all-ones is the same as bufr_missing_int() and bypass the range check.

@vsouvan
Copy link
Collaborator Author

vsouvan commented Apr 19, 2020

(by vanh-souvanlasy)
Fix committed in revision 330 of the trunk

@vsouvan vsouvan added this to the 0.8.7 milestone Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant