Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aspect ratio as a parameter for image requests #163

Open
ChrisJohnNOAA opened this issue Jun 26, 2024 · 1 comment · May be fixed by #243
Open

Add aspect ratio as a parameter for image requests #163

ChrisJohnNOAA opened this issue Jun 26, 2024 · 1 comment · May be fixed by #243
Labels
enhancement good first issue This is suitable for a first time programming project. Straightforward I'm sure this can be done.

Comments

@ChrisJohnNOAA
Copy link
Contributor

&.yRange=min|max|ascending|scale|aspect

aspect would be a decimal between 0.01 and 100

originally requested in email by John Kerfoot.

I believe this requires modifying EDDGrid and EDDTable saveAsImage method (in both) to parse the new value.
@ChrisJohnNOAA ChrisJohnNOAA added enhancement good first issue This is suitable for a first time programming project. Straightforward I'm sure this can be done. labels Jun 26, 2024
@yousifelboukhary yousifelboukhary linked a pull request Jan 20, 2025 that will close this issue
Open
2 tasks
@yousifelboukhary
Copy link

@ChrisJohnNOAA
I opened #243 this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue This is suitable for a first time programming project. Straightforward I'm sure this can be done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add aspect ratio as a parameter for image requests yousifelboukhary/erddap
2 participants
@yousifelboukhary @ChrisJohnNOAA