Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename turbulent_kinetic_energy and change units #70

Open
nusbaume opened this issue Jun 14, 2024 · 4 comments
Open

Rename turbulent_kinetic_energy and change units #70

nusbaume opened this issue Jun 14, 2024 · 4 comments

Comments

@nusbaume
Copy link
Collaborator

nusbaume commented Jun 14, 2024

Currently the repo contains the standard name turbulent_kinetic_energy with units of J. However, in atmospheric science the default units for TKE is J kg-1, which are the units for the variable in both SIMA and the UFS (although the diagnostic output in the UFS has it mislabeled as just J).

Thus in order to clarify the units, and to better match the CF-conventions, it was decided to change the standard name in this repo to be specific_turbulent_kinetic_energy, and to change the units to J kg-1.

@nusbaume nusbaume added the name changing This issue or PR is requesting a change to an existing standard name. label Jun 14, 2024
@dudhia
Copy link
Collaborator

dudhia commented Jun 14, 2024 via email

@nusbaume
Copy link
Collaborator Author

@dudhia We discussed this at the CCPP framework meeting and landed on the word "specific" for two reasons:

  1. It matches what is listed in the CF-conventions, as there is no turbulent_kinetic_energy, only specific_turbuent_kinetic_energy, and the conventions make a point that the word specific means "per unit mass".

  2. We generally wanted to lean towards being more verbose in order to remove any chance of ambiguity. Since technically the SI unit for energy is J, we thought adding specific_ would make it clear to non-atmospheric scientists that the units should be J kg-1.

You do make a really good point though that other "energy" quantities are also per unit mass, and ideally it would be good to have the names of these quantities be consistent (e.g. they either all have specific_ or none of them do). I'll make it an agenda item for the next framework/standard names meeting to discuss it some more (although if people watching this repo have opinions then feel free to respond here on this issue as well).

@mkavulich
Copy link
Collaborator

@dudhia I agree that terms for which there is a standard use that implies specific quantities (such as CAPE) this renaming is not needed. This discussion is specifically (heh) about TKE. Doing some literature review (AKA googling "turbulent kinetic energy units") it seems like the standard usage implies "specific" units (energy per unit mass), so maybe this renaming is not necessary; just re-defining the units to J kg^-1 would be sufficient.

@nusbaume
Copy link
Collaborator Author

After discussing this at the CCPP-framework, we decided to keep the name as turbulent_kinetic_energy, but to change the units to J kg-1. I'll go ahead and remove the "name changing" label to make it clear that the standard name itself will remain the same.

@nusbaume nusbaume removed the name changing This issue or PR is requesting a change to an existing standard name. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants