Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of new features needed #2113

Open
4 of 12 tasks
wwieder opened this issue Aug 18, 2023 · 17 comments
Open
4 of 12 tasks

Documentation of new features needed #2113

wwieder opened this issue Aug 18, 2023 · 17 comments
Assignees
Labels
documentation additions or edits to user-facing documentation

Comments

@wwieder
Copy link
Contributor

wwieder commented Aug 18, 2023

We have a number of new features that have been added to the model recently that should be documented in the tech note and user's guide. I've started a short list of these and tried to suggest people who can help with this. Maybe at an upcoming meeting we can discuss how to efficiently get these contributions into our documentation?

And more that are moving through the queue like:

I'm sure there are others we need to add to this list...

@wwieder wwieder added documentation additions or edits to user-facing documentation next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Aug 18, 2023
@wwieder wwieder self-assigned this Aug 18, 2023
@mvdebolskiy
Copy link
Contributor

@wwieder Tech note documentation writeup was included in the #1787. See the Snow and Soil Temperatures section at master. If you want a user-guide write-up for the feature, i can make a quick PR with that.

@samsrabin
Copy link
Collaborator

Agreed. Should my things go under "Running with special cases," then?

@wwieder
Copy link
Contributor Author

wwieder commented Aug 18, 2023

Thanks @mvdebolskiy, that's excellent! do we just have to 'build' the tech note again for these to changes to show up on the wiki? Is there additional, practical information that should be included in the user's guide for excess ice? I'm not familiar with how to run with this feature?

@samsrabin I'm not sure if the crop calendar work belongs with other crop model documentation or under [special cases in the user's guide]? Are the crop calendars not going to be on by default for CTSM5.1 crop simulations?

@samsrabin
Copy link
Collaborator

samsrabin commented Aug 18, 2023

That's right, @wwieder. All I've done so far is add prescribed static crop calendars, which of course don't allow prognostic seasonal shifts. So "special cases" is probably more appropriate.

@mvdebolskiy
Copy link
Contributor

mvdebolskiy commented Aug 18, 2023

Thanks @mvdebolskiy, that's excellent! do we just have to 'build' the tech note again for these to changes to show up on the wiki?

Yes.

Is there additional, practical information that should be included in the user's guide for excess ice? I'm not familiar with how to run with this feature?

Might be. I can add an entry to the "Run with special cases" about how initialization works and additional spinup required. However, it's described in the papers linked in the tech note.

@cenlinhe
Copy link
Contributor

@wwieder I am happy to contribute to the documentation for the SNICAR updates. Please let me know how I should proceed (e.g., prepare a word doc and send it to the CTSM team?) and when you will need it. Thanks!

@TeaganKing
Copy link
Contributor

TeaganKing commented Aug 18, 2023

@wwieder Do we want to add a new tech note section (eg, 2.33) for running with NEON? I'm not sure that it would fit under other pre-existing sections. I'd be happy to put something together for run_neon in general, as well as including some PRISM details, and make a PR to update the tech note.

Can you clarify where in the user's guide you would want this?

@dlawrenncar
Copy link
Contributor

dlawrenncar commented Aug 18, 2023 via email

@samsrabin
Copy link
Collaborator

Definitely agree, @dlawrenncar. I'll send you et al. an email. For now, I have some ideas for "easy [prognostic] wins" in issue #1928.

@dmleung
Copy link
Contributor

dmleung commented Aug 18, 2023

Hi, I can write the dust updates for the tech note too!

@mvdebolskiy
Copy link
Contributor

@wwieder Are you making a PR I can contribute to, or should I just make a separate one?

@wwieder
Copy link
Contributor Author

wwieder commented Aug 21, 2023

You can make a new one, @mvdebolskiy. thanks.

@wwieder
Copy link
Contributor Author

wwieder commented Aug 21, 2023

Good question, @TeaganKing. I think we'll want to update the user's guide for NEON cases in section 1.6. I'd imagine this may be a larger overhaul for running point and regional cases with our new workflows. Does this make sense to others?

@olyson
Copy link
Contributor

olyson commented Aug 23, 2023

@olyson will document the surface roughness parameterization.

@billsacks billsacks removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 5, 2023
@samsrabin samsrabin linked a pull request Oct 6, 2023 that will close this issue
@mvdebolskiy
Copy link
Contributor

@samsrabin regarding history fields. links in this section do not work.

@samsrabin
Copy link
Collaborator

samsrabin commented Jan 2, 2024

Marking the tillage and residue removal tasks as done, as I've added documentation to those PRs (#2040, #2297) that will come in once approved.

Also marked the tillage and excess ice tasks as done.

@samsrabin samsrabin added this to the ctsm6.0.0 (code freeze) milestone May 13, 2024
@mvdebolskiy
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation additions or edits to user-facing documentation
Projects
Status: Back Burner (or lower priority)
Development

No branches or pull requests

9 participants