Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SNICAR parameter to parameter file #2247

Closed
wwieder opened this issue Nov 10, 2023 · 2 comments · Fixed by #2258
Closed

Move SNICAR parameter to parameter file #2247

wwieder opened this issue Nov 10, 2023 · 2 comments · Fixed by #2258
Assignees
Labels
enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations support user or developer needs help

Comments

@wwieder
Copy link
Contributor

wwieder commented Nov 10, 2023

In this thread, @cenlinhe recommended moving the following parameters to the CLM parameter file.
(1) C2_liq_Brun89 (wet aging coeff, on parameter file),
(2) snw_rds_refrz (refrozne grain size, on parameter file),
(3) fresh_snw_rds_max (max fresh snow grain size) AerosolMod.F90,
(4) snw_rds_min (cold snow size), AerosolMod.F90
(5) scvng_fct_mlt_bcphi, scvng_fct_mlt_bcpho, scvng_fct_mlt_dst1~4 src/biogeophys/SnowHydrologyMod.F90

This isn't urgent, but could be helpful for subsequent OAAT parameter perturbation experiments as we look at tuning snow albedos.

@wwieder wwieder added this to the PPE milestone Nov 10, 2023
@wwieder wwieder removed this from the PPE milestone Nov 10, 2023
@wwieder wwieder added enhancement new capability or improved behavior of existing capability support user or developer needs help next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Nov 10, 2023
@ekluzek ekluzek added priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Nov 16, 2023
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Nov 17, 2023

Linking (as related) another list of snow params being discussed that already appears in the params file.

These are the params that I need to add to the params file to complete this issue:
(3) fresh_snw_rds_max (max fresh snow grain size) AerosolMod.F90,
(4) snw_rds_min (cold snow size), AerosolMod.F90
(5) scvng_fct_mlt_bcphi, scvng_fct_mlt_bcpho, scvng_fct_mlt_dst1~4 src/biogeophys/SnowHydrologyMod.F90

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Nov 18, 2023

This parameter (fresh_snw_rds_max) moved from the namelist to the params file. I have a feeling this means that I need to update the clm50 and clm45 params files, as well.

Now that I think about it, I need to add all these params to the clm50 and clm45 params files.

slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this issue Nov 18, 2023
samsrabin added a commit to samsrabin/CTSM that referenced this issue Nov 27, 2023
New params files for Meier roughness, MIMICS, SNICAR, and with changes to leafcn and k*_nonmyc

1) Start using existing new params file for Meier roughness:
/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/paramdata/ctsm51_params.RMz0.c231011.nc
and include bug-fix ESCOMP#2219
2) Update forcing heights per ESCOMP#2071.
3) Update params file for MIMICS per ESCOMP#1845.
4) Make leafcn for pfts 15 and 16 the same per ESCOMP#2184.
5) Switch the values of params kc_nonmyc and kn_nonmyc per ESCOMP#2120.
6) Move SNICAR parameters to params file per ESCOMP#2247.

Changes answers. Details in PR ESCOMP#2258 and in the ChangeLog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations support user or developer needs help
3 participants