-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment text field too large #272
Comments
I cannot replicate this problem. For me, the edit window is 100% of the width of the brower. I have changed this value, and the edit window shrinks accordingly. The %width of the edit window stays constant even as I change the size of the browser window. I am using linux, tested with both Firefox and Chrome. It looks like you are using Safari on OSX. Have you tried with another browser? What happens if you alter the size of the browser window? |
Also, is CFG_WEBCOMMENT_USE_RICH_TEXT_EDITOR set to False for you? |
I attach a screenshot from latest Firefox on OS X. It is the same as in Safari, i.e. the box is slightly overflowing over the Making the |
Also that bullet list at the top ("Information, References...") should be really styled as a list of tabs. |
Interesting. I don't have the background grey, but otherwise the page looks the same as your Firefox. I'm going to just change the width to 80% and add a left margin of 20px or something like that. Emmanuel, what do you mean, exactly? |
Emanuel, shoudn't this (tabs style, page borders) be solved by some common B2share base style used by all pages? |
If I look at the Style Editor for the main page, there are two main CSS files, css/00-invenio.... and css/90-invenio... On the comments page, only the css/00-invenio..... file is used. |
..but I can't see how the CSS files are actually set in the pages. |
The invenio's default record page is multitab, but as we previously discussed, our template doesn't work properly with this feature and therefore we have this deformed page. On friday I talked with Klara and Mikael and we agreed that we should embed the current comment page in the record page, and have something similar Zenodo's record page. Also I'll try to remove additional tabs and only keep "comment" & "review" tabs (at least for now). |
Judging from my very recent experience with the download button issue, it's probable that this page is (also) rendered using the legacy routing system. The file/class would be, if I am right, webcomment_webinterface.py / WebInterfaceCommentsPages. |
... and I very much agree that it's better to have the comments inside the record page, not on a separate one |
Is that the solution then? Because I don't know how I'd go about embedding the comments inside the record page in the next day or two. |
I guess so, but it takes time to be done.... :/ For now I think we just need to improve the current page format and only change the size of the field. |
Changing the width of the field is simple, but I can't work out how to make any css changes to centre it or add a left margin. If it was a simple html file it would be easy, but this is a python template, and I can't see how any css is appllied at all. |
So I've pushed a short-term fix to shrink the comments box to 80% width and move it in 20 pixels. (Was much harder than it should have been until I stumbled upon the fact that I could embed a style within the div element!) |
This has been merged, we can close it |
See the screenshot. Default size is bigger than my window. There is no reason for it to be this big.
The text was updated successfully, but these errors were encountered: