Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment text field too large #272

Closed
stranak opened this issue Apr 22, 2014 · 16 comments
Closed

Comment text field too large #272

stranak opened this issue Apr 22, 2014 · 16 comments
Labels
Milestone

Comments

@stranak
Copy link

stranak commented Apr 22, 2014

See the screenshot. Default size is bigger than my window. There is no reason for it to be this big.

screen shot 2014-04-22 at 14 02 14

@stranak stranak added this to the 1.0 – Summer release milestone Apr 22, 2014
@stranak stranak modified the milestones: 0.6, 1.0 – Summer release, 0.5.1 Apr 22, 2014
@stranak stranak assigned SarahBA and unassigned SarahBA Apr 28, 2014
@huwmorris huwmorris self-assigned this Apr 28, 2014
@huwmorris
Copy link

I cannot replicate this problem. For me, the edit window is 100% of the width of the brower. I have changed this value, and the edit window shrinks accordingly. The %width of the edit window stays constant even as I change the size of the browser window.

I am using linux, tested with both Firefox and Chrome. It looks like you are using Safari on OSX. Have you tried with another browser? What happens if you alter the size of the browser window?

@huwmorris
Copy link

Also, is CFG_WEBCOMMENT_USE_RICH_TEXT_EDITOR set to False for you?

@stranak
Copy link
Author

stranak commented Apr 28, 2014

I attach a screenshot from latest Firefox on OS X. It is the same as in Safari, i.e. the box is slightly overflowing over the div with the background gray.

Making the textarea widget something like 95% kind of solves it, but the page is quite ugly. It needs a bit of CSS. At least give the page some left margin and make the textarea much smaller in general. All modern browsers allow users to enlarge it if they want to. See the second screenshot. The first one is scrolled to the right to see better the textarea problem, the second is a normal view with <textarea style="width:90% >. Still quite ugly.

screen shot 2014-04-28 at 16 51 06

screen shot 2014-04-28 at 16 58 12

@emanueldima
Copy link
Contributor

Also that bullet list at the top ("Information, References...") should be really styled as a list of tabs.

@huwmorris
Copy link

Interesting. I don't have the background grey, but otherwise the page looks the same as your Firefox. I'm going to just change the width to 80% and add a left margin of 20px or something like that.

Emmanuel, what do you mean, exactly?

@stranak
Copy link
Author

stranak commented Apr 28, 2014

Emanuel, shoudn't this (tabs style, page borders) be solved by some common B2share base style used by all pages?

@huwmorris
Copy link

If I look at the Style Editor for the main page, there are two main CSS files, css/00-invenio.... and css/90-invenio...

On the comments page, only the css/00-invenio..... file is used.

@huwmorris
Copy link

..but I can't see how the CSS files are actually set in the pages.

@SarahBA
Copy link
Contributor

SarahBA commented Apr 28, 2014

The invenio's default record page is multitab, but as we previously discussed, our template doesn't work properly with this feature and therefore we have this deformed page. On friday I talked with Klara and Mikael and we agreed that we should embed the current comment page in the record page, and have something similar Zenodo's record page. Also I'll try to remove additional tabs and only keep "comment" & "review" tabs (at least for now).

@emanueldima
Copy link
Contributor

Judging from my very recent experience with the download button issue, it's probable that this page is (also) rendered using the legacy routing system. The file/class would be, if I am right, webcomment_webinterface.py / WebInterfaceCommentsPages.

@emanueldima
Copy link
Contributor

... and I very much agree that it's better to have the comments inside the record page, not on a separate one

@huwmorris
Copy link

Is that the solution then? Because I don't know how I'd go about embedding the comments inside the record page in the next day or two.

@SarahBA
Copy link
Contributor

SarahBA commented Apr 28, 2014

I guess so, but it takes time to be done.... :/ For now I think we just need to improve the current page format and only change the size of the field.

@emanueldima emanueldima removed the Easy label Apr 29, 2014
@huwmorris
Copy link

Changing the width of the field is simple, but I can't work out how to make any css changes to centre it or add a left margin. If it was a simple html file it would be easy, but this is a python template, and I can't see how any css is appllied at all.

@huwmorris
Copy link

So I've pushed a short-term fix to shrink the comments box to 80% width and move it in 20 pixels. (Was much harder than it should have been until I stumbled upon the fact that I could embed a style within the div element!)

@emanueldima
Copy link
Contributor

This has been merged, we can close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants