Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to parse ESQL with nested block comments #96

Closed
jfluitsma opened this issue May 9, 2018 · 4 comments
Closed

Unable to parse ESQL with nested block comments #96

jfluitsma opened this issue May 9, 2018 · 4 comments

Comments

@jfluitsma
Copy link
Contributor

Hi Thomas,

I got an issue with nested comments in ESQL. It looks simitar to #83 but in our case the code is valid.
`/* -----------------------------
... lines ommitted

  • Example CALL GFUNC_BrokerLog(
  • /* ifName */ 'myTestFlow'
  • /* msgCode / 'KZ', / msgType */ 'INF',
  • /* srcSys / 'srcFrom', / srcMsg */ srcMsgBitStream,
  • /* trgSys / 'trgTo', / trgMsg */ NULL,
  • /* shrtDsc / 'abc-def', / longDsc */ NULL
  • );
    ... lines ommitted
    */`

It is a long time ago I looked into the code so I hope you can find the solution quicker then I can.

Regards,
Jan Fluitsma

@ThomasPohl ThomasPohl added the bug label May 12, 2018
@ThomasPohl
Copy link
Member

Hi Jan,
isn't there a comma missing? I would expect a comma after 'myTestFlow' and before 'INF'

Regards
Thomas

@jfluitsma
Copy link
Contributor Author

Hi Thomas,

Thanks for the reply.

The comma should not matter, it is all in a block comment.
Difference with #83 is that the code in that issue the block comments were not balanced, it has 1 opening block comment followed by 2 closing block comments.
In our case the block comments are balanced.

Regards,
Jan

@ThomasPohl
Copy link
Member

Hi Jan,

now understood the issue. That won't be easy. I am matching comments with regular expressions. Right now I have no idea how to specify a regex for these nested comments.
Nevertheless is it a bug in the plugin.

@jfluitsma
Copy link
Contributor Author

jfluitsma commented Jun 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants