Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviews result in two messages being sent #26

Open
Ghabry opened this issue Jan 9, 2025 · 1 comment
Open

Reviews result in two messages being sent #26

Ghabry opened this issue Jan 9, 2025 · 1 comment

Comments

@Ghabry
Copy link
Member

Ghabry commented Jan 9, 2025

Looks like Github changed slightly the interface for reviews:

In my previous commit I fixed a 500 error when an empty body is received but this results now in two messages.

e.g.

> carstene1ns reviewed pull request 490
> carstene1ns commented on pull request 490
> [The review message]

The documentation of the API is lacking so I'm just guessing a bit here what would make sense in handling this. 😅


When it's a pull_request_review: These always have empty body payloads now (null).

Ignore them, except when review.state is approved or changes_requested.

review.state == commented is the part that spams now.


When it's a pull_request_review_comment: No changes required.

@Ghabry
Copy link
Member Author

Ghabry commented Jan 9, 2025

unrelated:

There are also multiple 500 errors for unhandled events such as check_suite.completed.

But it should actually return 204 in this case. So likely reading some missing key from the JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant