We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looks like Github changed slightly the interface for reviews:
In my previous commit I fixed a 500 error when an empty body is received but this results now in two messages.
e.g.
> carstene1ns reviewed pull request 490 > carstene1ns commented on pull request 490 > [The review message]
The documentation of the API is lacking so I'm just guessing a bit here what would make sense in handling this. 😅
When it's a pull_request_review: These always have empty body payloads now (null).
pull_request_review
body
null
Ignore them, except when review.state is approved or changes_requested.
review.state
approved
changes_requested
review.state == commented is the part that spams now.
review.state == commented
When it's a pull_request_review_comment: No changes required.
pull_request_review_comment
The text was updated successfully, but these errors were encountered:
unrelated:
There are also multiple 500 errors for unhandled events such as check_suite.completed.
check_suite.completed
But it should actually return 204 in this case. So likely reading some missing key from the JSON.
Sorry, something went wrong.
No branches or pull requests
Looks like Github changed slightly the interface for reviews:
In my previous commit I fixed a 500 error when an empty body is received but this results now in two messages.
e.g.
The documentation of the API is lacking so I'm just guessing a bit here what would make sense in handling this. 😅
When it's a
pull_request_review
: These always have emptybody
payloads now (null
).Ignore them, except when
review.state
isapproved
orchanges_requested
.review.state == commented
is the part that spams now.When it's a
pull_request_review_comment
: No changes required.The text was updated successfully, but these errors were encountered: