Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGM of main title does not change when loading game with Maniacs 200128 #3176

Closed
Br4ssman opened this issue Dec 20, 2023 · 5 comments
Closed

Comments

@Br4ssman
Copy link

The game incorporates a custom save/load system with this version of Maniacs.

The process to test this is to get to the title screen, load game and note that the music is set from the map itself, this problem is not remedied until you change area, there is a fade out music and then starts the song of the new area.

I send it to @Ghabry privately as it is a Steam game for spring 2024.

Thank you very much.

@Mimigris
Copy link

Seems similar to #3029 that was fixed in the continuous build months ago, just to be sure, have you checked if you were able to reproduce it on the continuous build?

@Br4ssman
Copy link
Author

I will provide some more information:
I have tested the continuous build, the result is the same, I will explain.

This is the song configured in this map and it sounds like this after passing the intro (new game):
https://github.com/EasyRPG/Player/assets/18174790/054d0425-1a58-4acf-8d0f-fc37a7d555c4

This is how it is configured:
bgm_conf

If I proceed to resume a game and load normally, the main menu music continues to play:
https://github.com/EasyRPG/Player/assets/18174790/01c2212f-5ae3-40f3-b963-15a94f5bc93b

Here is a partial sample of the customised loading screen:
custom_loadgame

@Br4ssman
Copy link
Author

Br4ssman commented Jan 9, 2024

I add more missing details:

The title screen acts from a map (custom title menu), not the default of RPGM.
On the other hand, I'm trying to test if it has a solution from the Maker itself (playing BGM: OFF before loading), so far without success.

There is also no change if the music is configured from the map properties or if it is played from a specific event, so far the options are exhausted.

EDIT: There seems to be a way to fix it FROM RM: common event, Player variable by Map ID and if it matches the music plays.

EDIT 2: It's important to note, that the above fix works as long as the tune set in the map where the game was saved is OFF, even if the common event does its fix, as long as you set a tune other than OFF, the above error returns.

@Ghabry
Copy link
Member

Ghabry commented Mar 11, 2024

@Br4ssman Sorry I'm not sure if I missed it but I cannot find the file you sent me. Can you send it me again?

@Ghabry Ghabry added the Invalid label Mar 12, 2024
@Ghabry
Copy link
Member

Ghabry commented Mar 12, 2024

As @Mimigris already stated this was caused by an outdated version of the Player.

Though while testing the game I found a crash due to an incorrect value for a string var 2259b56

I added this to #3195 :)

@Ghabry Ghabry closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants