Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New buttons doesn't work on browser ported games #3280

Closed
Br4ssman opened this issue Oct 7, 2024 · 2 comments
Closed

New buttons doesn't work on browser ported games #3280

Br4ssman opened this issue Oct 7, 2024 · 2 comments
Labels
Emscripten WebAssembly/JavaScript port for web browsers Invalid

Comments

@Br4ssman
Copy link

Br4ssman commented Oct 7, 2024

Related to: #3279

I've recently ported a new browser game with the recent files that @Ghabry pointed out to me as data-key-code is obsolete.
However, with data-key-code the button (1 in this case) used to work, now it does not.

I have tested it before and after the changes made to updateTouchControlsVisibility on different sessions and devices to check.

Link: https://netherwareentertainment.com/online/?game=powerchars

@Ghabry
Copy link
Member

Ghabry commented Oct 8, 2024

According to this testing website https://w3c.github.io/uievents/tools/key-event-viewer.html

The key is called Digit1 for the 1 and Numpad1 for the key on the Numpad. Both should work.

@Br4ssman
Copy link
Author

Br4ssman commented Oct 8, 2024

Thanks,

it was that.

@Ghabry Ghabry added Emscripten WebAssembly/JavaScript port for web browsers Invalid labels Oct 8, 2024
@Ghabry Ghabry closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emscripten WebAssembly/JavaScript port for web browsers Invalid
Development

No branches or pull requests

2 participants