Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better abstraction for "Fixup" and "Setup" #371

Open
4 of 6 tasks
mateofio opened this issue May 26, 2020 · 0 comments
Open
4 of 6 tasks

Better abstraction for "Fixup" and "Setup" #371

mateofio opened this issue May 26, 2020 · 0 comments
Labels

Comments

@mateofio
Copy link
Contributor

mateofio commented May 26, 2020

There are a lot of cases where lcf save data has a sentinel value, which means to defer to the database.

For example if SaveMapInfo::chipset_id == -1 that means use the chipset from the map etc..

There are a few fields which do this logic directly in player when you request the field, while others have a FixUp() function in liblcf which is supposed to be called.

I'm not a huge fan of these fixup functions, maybe there is a better abstraction for this behavior? Also we should unify how we handle this between lcf and player

  • Actor
  • SaveActor
  • SaveSettings
  • SaveInventory
  • SaveMapInfo
  • Parameters
@mateofio mateofio changed the title Better abstraction for "fixup" Better abstraction for "Fixup" and "Setup" Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants